Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tcgc] fix onClient setting for parameters applied to interface @clientInitialization #1554

Merged
merged 2 commits into from
Sep 18, 2024
Merged

[tcgc] fix onClient setting for parameters applied to interface @clientInitialization #1554

merged 2 commits into from
Sep 18, 2024

Conversation

iscai-msft
Copy link
Contributor

fixes #1532

@azure-sdk
Copy link
Collaborator

All changed packages have been documented.

  • ✅ @azure-tools/typespec-azure-resource-manager
  • ✅ @azure-tools/typespec-client-generator-core
Show changes

@azure-tools/typespec-azure-resource-manager - feature ✏️

x-ms-skip-url-encoding should be replaced with allowReserved

@azure-tools/typespec-client-generator-core - breaking ✏️

  1. The kind for unknown renamed from any to unknown.,> 2. The values property in SdkUnionType renamed to variantTypes.,> 3. The values property in SdkTupleType renamed to valueTypes.,> 4. The example types for parameter, response and SdkType has been renamed to XXXExampleValue to emphasize that they are values instead of the example itself.,> 5. The @format decorator is no longer able to change the type of the property.

@azure-tools/typespec-client-generator-core - fix ✏️

Fix naming logic for anonymous model wrapped by HttpPart

@azure-tools/typespec-client-generator-core - fix ✏️

Fix subscriptionId for ARM SDK

@azure-tools/typespec-client-generator-core - fix ✏️

fix onClient setting for client initialization parameters applied to an interface

@azure-tools/typespec-client-generator-core - breaking ✏️

  1. change encode in SdkBuiltInType to optional.,> 2. no longer use the value of kind as encode when there is no encode on this type.

@azure-tools/typespec-client-generator-core - breaking ✏️

no longer export the SdkExampleValueBase interface. This type should have no usage in downstream consumer's code. If there is any usage, please replace it with SdkExampleValue.

@tadelesh tadelesh merged commit d8c73dd into release/september-2024 Sep 18, 2024
20 of 22 checks passed
@tadelesh tadelesh deleted the onClientSetting branch September 18, 2024 05:39
markcowl pushed a commit to markcowl/typespec-azure that referenced this pull request Sep 24, 2024
@iscai-msft @markcowl
[tcgc] fix onClient setting for parameters applied to interface @cl…
16b3355 
…ientInitialization (Azure#1554)

fixes Azure#1532

---------

Co-authored-by: iscai-msft <[email protected]>
markcowl pushed a commit to markcowl/typespec-azure that referenced this pull request Sep 26, 2024
@iscai-msft @markcowl
[tcgc] fix onClient setting for parameters applied to interface @cl…
693630a 
…ientInitialization (Azure#1554)

fixes Azure#1532

---------

Co-authored-by: iscai-msft <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tadelesh tadelesh tadelesh approved these changes

@lmazuel lmazuel Awaiting requested review from lmazuel lmazuel is a code owner

@m-nash m-nash Awaiting requested review from m-nash m-nash is a code owner

@srnagar srnagar Awaiting requested review from srnagar srnagar is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@bterlson bterlson Awaiting requested review from bterlson bterlson is a code owner

@markcowl markcowl Awaiting requested review from markcowl markcowl is a code owner

@allenjzhang allenjzhang Awaiting requested review from allenjzhang allenjzhang is a code owner

@timotheeguerin timotheeguerin Awaiting requested review from timotheeguerin timotheeguerin is a code owner

@chunyu3 chunyu3 Awaiting requested review from chunyu3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iscai-msft @azure-sdk @tadelesh